Skip to content

Deprecate MPS backend#18425

Merged
metascroy merged 4 commits intopytorch:mainfrom
metascroy:export-D97825833
Mar 24, 2026
Merged

Deprecate MPS backend#18425
metascroy merged 4 commits intopytorch:mainfrom
metascroy:export-D97825833

Conversation

@metascroy
Copy link
Copy Markdown
Contributor

@metascroy metascroy commented Mar 23, 2026

Differential Revision: D97825833

@metascroy @facebook-github-bot
Deprecate MPS backend
fe4c28a 
Differential Revision: D97825833
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 23, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit fa4a507 with merge base 2309bfa (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Mar 23, 2026

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97825833.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Mar 23, 2026

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D97825833.

digantdesai
digantdesai reviewed Mar 23, 2026
View reviewed changes
Comment thread backends/apple/mps/__init__.py
@@ -1 +1 @@
#
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to disable any high freq tests? we can keep them on slow freq or disable them in favor of just nighly runs.

Copy link
Copy Markdown
Contributor Author

@metascroy metascroy Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean lower the frequency of existing MPS tests due to planned deprecation?

If so, I'd rather leave them running. We shouldn't break MPS during the deprecation period.

@metascroy metascroy merged commit 765660b into pytorch:main Mar 24, 2026
392 of 405 checks passed
@metascroy
Copy link
Copy Markdown
Contributor Author

metascroy commented Mar 24, 2026

@pytorchbot cherry-pick --onto release/1.2 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 24, 2026
@metascroy @pytorchbot
Deprecate MPS backend (#18425)
03a14ef 
Differential Revision: D97825833

(cherry picked from commit 765660b)
@pytorchbot
Copy link
Copy Markdown
Collaborator

pytorchbot commented Mar 24, 2026

Cherry picking #18425

The cherry pick PR is at #18470 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Mar 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@cccclai cccclai Awaiting requested review from cccclai

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@metascroy @pytorchbot @digantdesai @manuelcandales